Fix: make sure code cov reports generate and upload #469
Conversation
|
this is still not working - please do not merge until we get it working. i'll turn it into a draft. |
|
my theory is that nox saves the coverage.xml file into a temp envt so ci can't find it. somehow nox needs to spit out the file so ci can find it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
=========================================
+ Coverage 0 89.51% +89.51%
=========================================
Files 0 10 +10
Lines 0 1878 +1878
Branches 0 150 +150
=========================================
+ Hits 0 1681 +1681
- Misses 0 156 +156
- Partials 0 41 +41 ☔ View full report in Codecov by Sentry. |
|
as you can see codecov is now reporting on test coverage as it should and it's uploading as well. this is ready for review. something must have changed in the pytest-cov package as the approach we used previously did work. (well in a makefile envt). But i like this approach better as it's much more clear which flags and values pair. |
lwasser
changed the title
|
This is also ready for a review (and merge??) if y'all agree. |
closes #468
Description
Adds the token that i added to our repo to the build
Type of change
Select the statement best describes this pull request.
Does your PR include tests
If you are fixing a bug or adding a feature, we appreciate (but do not require)
tests to support whatever fix of feature you're implementing.
Did you include your contribution to the change log?
changelog.mdis up-to-date.I am not sure this needs another changelog input from me.